Fix Flashbang & HE#270
Merged
Misaka-ZeroTwo merged 1 commit intoExMod-Team:scpsl14from Nov 30, 2024
obvEve:grenade-fix
Merged
Conversation
obvEve
commented
Nov 30, 2024
| // Only check friendlyFire if the FootPrint hasn't changed (Fix for Grenade not dealing damage because it's from a dead player) | ||
| // TODO rework FriendlyFireRule to make it compatible with Footprint | ||
| if (!attackerFootprint.Equals(new Footprint(attackerFootprint.Hub))) | ||
| if (!attackerFootprint.CompareLife(new Footprint(attackerFootprint.Hub))) |
| if ((instance.transform.position - player.Position).sqrMagnitude >= distance) | ||
| continue; | ||
| if (!ExiledEvents.Instance.Config.CanFlashbangsAffectThrower && instance.PreviousOwner.LifeIdentifier != new Footprint(referenceHub).LifeIdentifier) | ||
| if (!ExiledEvents.Instance.Config.CanFlashbangsAffectThrower && instance.PreviousOwner.CompareLife(player.ReferenceHub)) |
| { | ||
| List<Player> targetToAffect = ListPool<Player>.Pool.Get(); | ||
| foreach (ReferenceHub referenceHub in ReferenceHub.AllHubs) | ||
| foreach (Player player in Player.List) |
Member
Author
There was a problem hiding this comment.
is technically better since we call Player.Get() immediately after
Misaka-ZeroTwo
approved these changes
Nov 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes
Fix
What is the current behavior? (You can also link to an open issue here)
What is the new behavior? (if this is a feature change)
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Other information:
Types of changes
Submission checklist
Patches (if there are any changes related to Harmony patches)
Other